This repository has been archived by the owner on May 31, 2024. It is now read-only.
refactor: remove redundant YAML packages #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the time of making this commit, the package `github.com/ghodss/yaml` is no longer actively maintained. `sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively maintained by Kubernetes SIG. Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Juneezee
requested review from
kumare3,
EngHabu and
wild-endeavor
as code owners
Codecov Report
@@ Coverage Diff @@
## master #387 +/- ##
==========================================
+ Coverage 66.54% 67.32% +0.77%
==========================================
Files 145 145
Lines 6265 5230 -1035
==========================================
- Hits 4169 3521 -648
+ Misses 1816 1429 -387
Partials 280 280
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
eapolinario
approved these changes
Feb 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Remove redundant YAML packages:
github.com/ghodss/yamlandgopkg.in/yaml.v2Type
Are all requirements met?
Complete description
Currently four YAML packages are used:
github.com/ghodss/yamlgopkg.in/yaml.v2gopkg.in/yaml.v3sigs.k8s.io/yamlWe can keep only two of them:
gopkg.in/yaml.v3sigs.k8s.io/yamlThe package
github.com/ghodss/yamlis no longer actively maintained. See discussion in ghodss/yaml#80 and ghodss/yaml#75.sigs.k8s.io/yamlis a permanent fork ofghodss/yamland is actively maintained by Kubernetes SIG, also widely used in K8s projects.We are only using
gopkg.in/yaml.v2incmd/config/subcommand/project/project_config.go. Switching togopkg.in/yaml.v3doesn't introduce breaking change here.Tracking Issue
Follow-up issue
NA